Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE: Simplify device name string creation. #371

Merged
merged 1 commit into from
Sep 5, 2023
Merged

BLE: Simplify device name string creation. #371

merged 1 commit into from
Sep 5, 2023

Conversation

microbit-carlos
Copy link
Collaborator

@microbit-carlos microbit-carlos commented Sep 5, 2023 •
edited
Loading

Saw this when looking at #370, it's a small change that results in the same string, but it saves a bit of flash with gcc v10.3.

The bloatly CI workflow should post here the size diff.

The modelVersion instance is not used anywhere else, disName results in the same string and is not used anywhere else either.

@microbit-carlos
BLE: Simplify device name string creation.
50919f2 
It's a small change that results in the same string,
but it saves about 36 bytes of flash with gcc v10.3
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Build diff

Base commit: fbe41c4933f90134fc20c32049fa6b2b0637df60
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/6084596139

     VM SIZE    
 -------------- 
  -0.0%      -2    [section .text]
  -0.8%     -34    /home/runner/work/codal-microbit-v2/codal-microbit-v2/libraries/codal-microbit-v2/source/bluetooth/MicroBitBLEManager.cpp
  -0.0%     -36    TOTAL

@JohnVidler
Copy link
Collaborator

Looks good to me, lets get this merged in.

@JohnVidler JohnVidler merged commit ffe0265 into master Sep 5, 2023
28 checks passed
@JohnVidler JohnVidler deleted the ble-str-simpliciation branch September 5, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVidler JohnVidler Awaiting requested review from JohnVidler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microbit-carlos @JohnVidler